linux-mips
[Top] [All Lists]

Re: [PATCH 7/7] Allow unwind_stack() to return ra for leaf function

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 7/7] Allow unwind_stack() to return ra for leaf function
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Wed, 02 Aug 2006 18:56:34 +0200
Cc: vagabon.xyz@gmail.com, ralf@linux-mips.org, linux-mips@linux-mips.org
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:from; b=q8TrG9gFL+2C8ecMCVkwi4AUuA3yC6IoHL2PzVM8SAemhLvpeJSsPZgHvW6IZQ0s/OKdPoUz6+so/yHSwaZMIhJvEnxd2h/d+542JJWdWwOQqAD+RFGA07++6LvFt239BNZy/bquIypUwlndD0wFGSdouSFnfYQ/X71wH8wv5Cs=
In-reply-to: <20060803.010000.25909906.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <44D07C97.2040008@innova-card.com> <20060802.202540.10544424.nemoto@toshiba-tops.co.jp> <44D0A3B0.40601@innova-card.com> <20060803.010000.25909906.anemo@mba.ocn.ne.jp>
Reply-to: Franck <vagabon.xyz@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.4 (X11/20060614)
Atsushi Nemoto wrote:
> On Wed, 02 Aug 2006 15:08:00 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> 
> wrote:
>> does this updated patch make you really happy ? If so I'll resend the whole
>> updated patchset.
> 
> Yes, looks good for me.
> 
> Just one comment: no need to do "pc = pc != ra ? ra : 0" anymore.
> Just "pc = ra" is enough, isn't it?
> 

Well I let it just for cases where the caller does not reset ra after the first
call. It should be safter. But I can remove it if you want.

                Franck

<Prev in Thread] Current Thread [Next in Thread>