| To: | "Atsushi Nemoto" <anemo@mba.ocn.ne.jp> |
|---|---|
| Subject: | Re: [PATCH 7/7] Allow unwind_stack() to return ra for leaf function |
| From: | "Franck Bui-Huu" <vagabon.xyz@gmail.com> |
| Date: | Tue, 1 Aug 2006 21:38:18 +0200 |
| Cc: | ralf@linux-mips.org, linux-mips@linux-mips.org |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=qDuQsE7GVQe4IP7uwh8gDnUO1Ml1OXvkMVSVMgcSK3w47rlrOk52ewgoAeAiPvrfPSMD8g02+Vm+7mOXAZ1kapCXRxy2r12Mjos0Qwpgo01JqklwvNLS1drA1ZpOoLhHJ4n6mMjMEeLlzGVzoduZckABvZEALqbsFbcJnfxqj1M= |
| In-reply-to: | <20060802.004848.97296551.anemo@mba.ocn.ne.jp> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <11544244373398-git-send-email-vagabon.xyz@gmail.com> <1154424439969-git-send-email-vagabon.xyz@gmail.com> <20060802.004848.97296551.anemo@mba.ocn.ne.jp> |
| Sender: | linux-mips-bounce@linux-mips.org |
2006/8/1, Atsushi Nemoto <anemo@mba.ocn.ne.jp>: On Tue, 1 Aug 2006 11:27:17 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote: > Since get_frame_info() is more robust, unwind_stack() can > returns ra value for leaf functions. I think it is still fragile. The get_frame_info() might misdetect nested function as leaf. For example, I can craft this code:
Considering (wrongly) a nested function as a leaf one is not a big
issue. "ra" reg should _always_ store a valid address (nested or not).
The only (small) impact would be to skip an entry when showing the
backtrace.
--
Franck
|
| Previous by Date: | Re: [PATCH 6/7] Fix dump_stack(), Franck Bui-Huu |
|---|---|
| Next by Date: | Re: [PATCH 7/7] Allow unwind_stack() to return ra for leaf function, Atsushi Nemoto |
| Previous by Thread: | Re: [PATCH 7/7] Allow unwind_stack() to return ra for leaf function, Atsushi Nemoto |
| Next by Thread: | Re: [PATCH 7/7] Allow unwind_stack() to return ra for leaf function, Atsushi Nemoto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |