Re: [PATCH 6/7] Fix dump_stack()

["Franck Bui-Huu" <vagabon.xyz@gmail.com>]

2006/8/1, Atsushi Nemoto <anemo@mba.ocn.ne.jp>:
> On Tue, 01 Aug 2006 17:36:38 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> 
> wrote:
> > > Eliminating the #ifdef itself looks good, but if you cleared contents
> > > of the "regs" before prepare_frametrace, you will get less false
> > > entries in the output.
> >
> > well I don't see why...show_trace() is going to only use regs[29] which
> > is setup by prepare_frametrace()...
>
> If CONFIG_KALLSYMS was not set, show_trace() print all possible
> entries starting from the sp.  The sp value stored in "regs" by
> prepare_frametrace() will be little smaller one than the address of
> the "regs" itself.  So if some values like function addresses were in
> the "regs", show_trace() will report them.
OK, I'll do that.

BTW what about rename show_trace() into show_raw_backtrace() ?

--
              Franck