linux-mips
[Top] [All Lists]

Re: [PATCH 6/7] Fix dump_stack()

To: vagabon.xyz@gmail.com
Subject: Re: [PATCH 6/7] Fix dump_stack()
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Wed, 02 Aug 2006 00:08:37 +0900 (JST)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <1154424439852-git-send-email-vagabon.xyz@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <11544244373398-git-send-email-vagabon.xyz@gmail.com> <1154424439852-git-send-email-vagabon.xyz@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue,  1 Aug 2006 11:27:16 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> 
wrote:
> When CONFIG_KALLSYMS is not set stack local is not initialized. Therefore
> show_trace() won't display anything useful. This patch uses
> prepare_frametrace() to setup the stack pointer before calling
> show_trace().

It's not a bug.  The original show_trace() needs an address on stack
and dump_stack() surely give it by taking an address of local
variable.

Eliminating the #ifdef itself looks good, but if you cleared contents
of the "regs" before prepare_frametrace, you will get less false
entries in the output.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>