| To: | anemo@mba.ocn.ne.jp |
|---|---|
| Subject: | [PATCH 3/7] Make frame_info_init() more readable. |
| From: | Franck Bui-Huu <vagabon.xyz@gmail.com> |
| Date: | Tue, 1 Aug 2006 11:27:13 +0200 |
| Cc: | ralf@linux-mips.org, linux-mips@linux-mips.org, Franck Bui-Huu <vagabon.xyz@gmail.com> |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=Ze+4QAX5xuVlquWRT1s77yhGl1iZPJ3IaWvFKkDfRXCCWoCcr3MNmwFO0NfT/ZGML4ng8DKtT2yJqkHSFU5b/apVM5irKSg1vkamoDIClyHzEV9F1Ii0nDHsTrB+C02ckaubhWHNpwcp6IAVW5UIwMKVnZYEbC2HIqymmv2r8So= |
| In-reply-to: | <11544244373398-git-send-email-vagabon.xyz@gmail.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <11544244373398-git-send-email-vagabon.xyz@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
Signed-off-by: Franck Bui-Huu <vagabon.xyz@gmail.com>
---
arch/mips/kernel/process.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
index 333f0bb..539b23b 100644
--- a/arch/mips/kernel/process.c
+++ b/arch/mips/kernel/process.c
@@ -364,15 +364,15 @@ #else
mfinfo[0].func = schedule;
schedule_frame = &mfinfo[0];
#endif
- for (i = 0; i < ARRAY_SIZE(mfinfo) && mfinfo[i].func; i++) {
- struct mips_frame_info *info = &mfinfo[i];
- if (get_frame_info(info)) {
- /* leaf or unknown */
- if (info->func == schedule)
- printk("Can't analyze prologue code at %p\n",
- info->func);
- }
- }
+ for (i = 0; i < ARRAY_SIZE(mfinfo) && mfinfo[i].func; i++)
+ get_frame_info(mfinfo + i);
+
+ /*
+ * Without schedule() frame info, result given by
+ * thread_saved_pc() and get_wchan() are not reliable.
+ */
+ if (schedule_frame->pc_offset < 0)
+ printk("Can't analyze schedule() prologue at %p\n", schedule);
mfinfo_num = i;
return 0;
--
1.4.2.rc2
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/7] Make get_frame_info() more robust, Franck Bui-Huu |
|---|---|
| Next by Date: | [PATCH 4/7] Remove unused MODULE_RANGE macro., Franck Bui-Huu |
| Previous by Thread: | [PATCH 2/7] Make get_frame_info() more robust, Franck Bui-Huu |
| Next by Thread: | [PATCH 4/7] Remove unused MODULE_RANGE macro., Franck Bui-Huu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |