linux-mips
[Top] [All Lists]

Re: [PATCH] dump_stack() based on prologue code analysis

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] dump_stack() based on prologue code analysis
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Mon, 31 Jul 2006 17:51:22 +0200
Cc: vagabon.xyz@gmail.com, linux-mips@linux-mips.org, ralf@linux-mips.org
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:from; b=DiCc0JkvJ5vXrD7Fc7Xz/WUzhz9kYtIM6wKtd/X6jy4kYHhc5BE2J8WVKIKHQ8gT7Hc/KMYsU1T8qjBibYuxU9krDT8blBEoTGXl7j+4cQ6ppc9hw6d6KXBzI17+hzyPV02mN+a3eSTij9PJOPn3b1NfgD4mYHcwZ9D6Jt0388I=
In-reply-to: <20060801.003311.75758612.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <44CDCA46.3030707@innova-card.com> <20060731.223923.115609520.anemo@mba.ocn.ne.jp> <44CE1494.4080801@innova-card.com> <20060801.003311.75758612.anemo@mba.ocn.ne.jp>
Reply-to: Franck <vagabon.xyz@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.4 (X11/20060614)
Atsushi Nemoto wrote:
> 
> Subject: [PATCH] make get_frame_info() more readable.
> 
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> 
> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
> index 8709a46..949efaf 100644
> --- a/arch/mips/kernel/process.c
> +++ b/arch/mips/kernel/process.c
> @@ -286,18 +286,17 @@ static int get_frame_info(struct mips_fr
>       int i;
>       void *func = info->func;
>       union mips_instruction *ip = (union mips_instruction *)func;

while you're at it, (union mips_instruction *) cast is useless and "func"
local too. Just write 

        union mips_instruction *ip = info->func;

is more readable, IMHO.

                Franck

<Prev in Thread] Current Thread [Next in Thread>