| To: | "Yoichi Yuasa" <yoichi_yuasa@tripeaks.co.jp> |
|---|---|
| Subject: | Re: [PATCH] Use compat code to translate siginfo_t for N32 |
| From: | "Peter Watkins" <treestem@gmail.com> |
| Date: | Fri, 28 Jul 2006 13:00:01 -0400 |
| Cc: | linux-mips@linux-mips.org |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=rYkyB4uZVvtfifzsokuStGaDHHrVDxDRsM1qbVMsN2KEvWdm0b5IrB7RxQVWjkIdvD8dGBnV1pzxdCrDDtagcow9UwEKaMxVom0HZPVs/gzNUfKHFCLEHmth9S0uq4WImz6O1zNGGVqlFKrXDzsJtw5Axyz2Y3v/CxSjhyavc/c= |
| In-reply-to: | <20060728104424.19e1bfaa.yoichi_yuasa@tripeaks.co.jp> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <44C94FEA.1010607@gmail.com> <20060728104424.19e1bfaa.yoichi_yuasa@tripeaks.co.jp> |
| Sender: | linux-mips-bounce@linux-mips.org |
Hello Yoichi, The attached patch addresses your points, and ends up cleaner and simpler. Except: > diff --git a/arch/mips/kernel/signal_n32.c b/arch/mips/kernel/signal_n32.c > index 477c533..f805bea 100644 > --- a/arch/mips/kernel/signal_n32.c > +++ b/arch/mips/kernel/signal_n32.c <snip> > @@ -74,7 +76,7 @@ #if ICACHE_REFILLS_WORKAROUND_WAR > #else > u32 rs_code[2]; /* signal trampoline */ > #endif > - struct siginfo rs_info; > + compat_siginfo_t rs_info; use struct compat_siginfo . I did not change this as it's currently consistent with the form used in signal32.c and signal_n32.c. If we want to change this, it seemed preferable to have another patch for just that purpose. - Peter
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] dump_stack() based on prologue code analysis, Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [PATCH] dump_stack() based on prologue code analysis, David Daney |
| Previous by Thread: | Re: [PATCH] Use compat code to translate siginfo_t for N32, Yoichi Yuasa |
| Next by Thread: | Re: ld: cannot open crt1.o, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |