linux-mips
[Top] [All Lists]

Re: [PATCH] do not count pages in holes with sparsemem

To: vagabon.xyz@gmail.com
Subject: Re: [PATCH] do not count pages in holes with sparsemem
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Thu, 27 Jul 2006 00:21:53 +0900 (JST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <44C77D49.90205@innova-card.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <44B3625B.7000700@innova-card.com> <20060711.222458.74752678.anemo@mba.ocn.ne.jp> <44C77D49.90205@innova-card.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 26 Jul 2006 16:33:45 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> 
wrote:
> I don't think that's correct to mark them as "reserved". Basicaly
> "reserved" means that it belongs to the kernel (code or data), these
> holes are not and we will end up to have wrong value as you pointed
> out.
> 
> Having quick look at sparsemem code, I don't think that it expects
> to have holes inside a section, do it ? If so you probably have to
> fix up your section size...

Yes, for such small holes, sparsemem and flatmem is same.  We can use
smaller section size to save more memory, but I suppose it will be a
bit slower.

> > Talking about nr_kernel_pages (calculated by zones_size[] and
> > zones_holes[]) and num_physpages, these values are used to determine
> > sizes of some kernel data structures, it would be better to set more
> > precise value for them.
> > 
> > While large holes in a section wastes some memory, make the section
> > size customizable might be a good idea.  Anyone?  ;-)
> > 
> 
> hey, you are working in this area, aren't you ? ;)

Well, not actively now since I'm comfort with 256MB section size :-)

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>