linux-mips
[Top] [All Lists]

Re: [PATCH] USB: removed a unbalanced #endif from ohci-au1xxx.c

To: Domen Puncer <domen.puncer@ultra.si>
Subject: Re: [PATCH] USB: removed a unbalanced #endif from ohci-au1xxx.c
From: Daniel Mack <daniel@caiaq.de>
Date: Sat, 15 Jul 2006 03:19:49 +0200
Cc: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>, linux-usb-devel <linux-usb-devel@lists.sourceforge.net>, linux-mips <linux-mips@linux-mips.org>
In-reply-to: <20060714084533.GP31105@domen.ultra.si>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060714162935.70502a98.yoichi_yuasa@tripeaks.co.jp> <20060714084533.GP31105@domen.ultra.si>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.11
On Fri, Jul 14, 2006 at 10:45:33AM +0200, Domen Puncer wrote:
> > Error message was:
> > In file included from drivers/usb/host/ohci-hcd.c:909:
> > drivers/usb/host/ohci-au1xxx.c:113:2: #endif without #if
> > 
> > Yoichi
> > 
> > Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> > 
> > diff -pruN -X 2.6.18-rc1/Documentation/dontdiff 
> > 2.6.18-rc1-orig/drivers/usb/host/ohci-au1xxx.c 
> > 2.6.18-rc1/drivers/usb/host/ohci-au1xxx.c
> > --- 2.6.18-rc1-orig/drivers/usb/host/ohci-au1xxx.c  2006-07-14 
> > 11:17:34.443211500 +0900
> > +++ 2.6.18-rc1/drivers/usb/host/ohci-au1xxx.c       2006-07-14 
> > 10:33:47.945949750 +0900
> > @@ -110,7 +110,6 @@ static void au1xxx_start_ohc(struct plat
> >  
> >     printk(KERN_DEBUG __FILE__
> >     ": Clock to USB host has been enabled \n");
> > -#endif
> >  }
> >  
> >  static void au1xxx_stop_ohc(struct platform_device *dev)

Yes, you're right.

> It looks like something went wrong with this patch
> http://www.linux-mips.org/git?p=linux.git;a=commitdiff;h=d14feb5ee4a46218f92b21ed52338b64130a151b
> 
> Looks like ehci-au1xxx.c might also be affected.

No, ehci-au1xxx.c looks ok to me, at least I was able to compile a
freshly updated git tree with only the above patch applied. Are there
any contrary reports?

Greets,
Daniel

<Prev in Thread] Current Thread [Next in Thread>