linux-mips
[Top] [All Lists]

Re: [patch rfc] au1xxx spi ported to spi layer

To: Domen Puncer <domen.puncer@ultra.si>
Subject: Re: [patch rfc] au1xxx spi ported to spi layer
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 28 Jun 2006 10:48:47 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20060628070750.GE31105@domen.ultra.si>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060628070750.GE31105@domen.ultra.si>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Wed, Jun 28, 2006 at 09:07:50AM +0200, Domen Puncer wrote:

> This is a port of Jordan Crouse's SPI patch to the SPI layer.
> Board definitions are only for dbau1200, flash should work with
> in-kernel driver. If someone wants the simple tmp121 driver,
> i can send it.
> 
> Hopefully someone finds this useful.
> 
> Signed-off-by: Domen Puncer <domen.puncer@ultra.si>

As for the arch/mips bits:

Acked-by: Ralf Baechle <ralf@linux-mips.org>

About 90% of this patch are SPI specific, so please feed this patch though
the SPI maintainer:

SPI SUBSYSTEM
P:      David Brownell
M:      dbrownell@users.sourceforge.net
L:      spi-devel-general@lists.sourceforge.net
S:      Maintained

One thing I noticed at a glance is the use of the sysv compatibility types,
notably uint.  Please don't use them in new code.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>