linux-mips
[Top] [All Lists]

Re: [PATCH] APM (emu) support

To: Rodolfo Giometti <giometti@linux.it>
Subject: Re: [PATCH] APM (emu) support
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 13 Jun 2006 14:34:37 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20060605154310.GF27426@enneenne.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060605154310.GF27426@enneenne.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Mon, Jun 05, 2006 at 05:43:10PM +0200, Rodolfo Giometti wrote:

> here my proposal to add APM (emu) support into mips tree. It's just
> the one for ARM adapted...
> 
> I have tested it on my au1100 based board with a battery pack. Also
> the command:
> 
>    $ apm --suspend
> 
> works correctly!

Looking good, indeed.

There is a sore spot though.  Your patch creates arch/mips/kernel/apm.c
as an essentially unmodified copy of arch/arch/kernel/apm.c and the
latter as you have found is actually portable code.  So I suggest you
rather move that file to drivers/char/ and use it for both architectures.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>