| To: | Rodolfo Giometti <giometti@linux.it> |
|---|---|
| Subject: | Re: [PATCH] au1000_eth.c Power Management, driver registration and module support |
| From: | Sergei Shtylyov <sshtylyov@ru.mvista.com> |
| Date: | Wed, 31 May 2006 19:01:02 +0400 |
| Cc: | jgarzik@pobox.com, netdev@vger.kernel.org, Linux-MIPS <linux-mips@linux-mips.org>, Jordan Crouse <jordan.crouse@amd.com> |
| In-reply-to: | <20060502150914.GE20543@gundam.enneenne.com> |
| Organization: | MontaVista Software Inc. |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20060405154711.GL7029@enneenne.com> <20060405222332.GO7029@enneenne.com> <20060405222620.GP7029@enneenne.com> <4435290C.50607@ru.mvista.com> <20060406155011.GC23424@enneenne.com> <4446857D.90507@ru.mvista.com> <20060502150914.GE20543@gundam.enneenne.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 |
Hello. Rodolfo Giometti wrote: here: http://ftp.enneenne.com/pub/misc/au1100-patches/linux/patch-au1000_eth-pm-and-registration the new version of my patch for au1000_eth.c who should implement: Also, as suggested by Sergei it: * uses physical addresses and not KSEG1-based virtual anymore and claims/releases the 4-byte MAC enable registers: wwpc:~# cat /proc/iomem 10500000-1050ffff : eth-base 10520000-10520003 : eth-mac* assigns to the Ethernet ports two consecutive MAC addresses:- dev->dev_addr[4] += 0x10; + ((unsigned long) macen_addr); + memcpy(ndev->dev_addr, au1000_mac_addr, sizeof(au1000_mac_addr)); + ndev->dev_addr[5] += 0x01;Ciao, Now that this is merged, Rodolfo's patch should probably preempt mine... but it looks like something was lost during the transition: I failed to seewhere SYS_PINFUNC register is actually read (the comment mentioning this was retained :-) to check whether Ethernet port 1 is enabled (its pins are shared w/GPIO)... Rodolfo WBR, Sergei |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] au1100fb fb_blank, Rodolfo Giometti |
|---|---|
| Next by Date: | Re: [PATCH] au1000_eth.c Power Management, driver registration and module support, Rodolfo Giometti |
| Previous by Thread: | Re: [PATCH] au1000_eth.c Power Management, driver registration and module support, Rodolfo Giometti |
| Next by Thread: | Re: [PATCH] au1000_eth.c Power Management, driver registration and module support, Rodolfo Giometti |
| Indexes: | [Date] [Thread] [Top] [All Lists] |