linux-mips
[Top] [All Lists]

Re: [PATCH] NEC EMMA2RH support

To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Subject: Re: [PATCH] NEC EMMA2RH support
From: dmitry pervushin <dpervushin@ru.mvista.com>
Date: Thu, 18 May 2006 15:08:28 +0400
Cc: linux-mips@linux-mips.org
In-reply-to: <20060518195404.663eba86.yoichi_yuasa@tripeaks.co.jp>
Organization: montavista
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1147946423.8223.4.camel@diimka-laptop> <20060518195404.663eba86.yoichi_yuasa@tripeaks.co.jp>
Reply-to: dpervushin@ru.mvista.com
Sender: linux-mips-bounce@linux-mips.org
On Чтв, 2006-05-18 at 19:54 +0900, Yoichi Yuasa wrote:
> Hi,
> 
> On Thu, 18 May 2006 14:00:23 +0400
> dmitry pervushin <dpervushin@ru.mvista.com> wrote:
> 
> > Index: linux-malta/arch/mips/emma2rh/markeins/int-handler.S
> > ===================================================================
> > --- /dev/null
> > +++ linux-malta/arch/mips/emma2rh/markeins/int-handler.S
> 
> You should rewrite the assembler interrupt handler to C code.
Why ?? Could you please comment the statement ? May be, I have
misunderstood the modern ways in linux kernel development, but I am
pretty sure that assembler interrupt handler will be faster than C
code. 
> 
> > Index: linux-malta/arch/mips/emma2rh/markeins/setup.c
> > ===================================================================
> > --- /dev/null
> > +++ linux-malta/arch/mips/emma2rh/markeins/setup.c
> > @@ -0,0 +1,208 @@
> 
> <snip>
> 
> > +}
> > +
> > +early_initcall(platform_setup);
> 
> early_initcall() already haven't existed.
> You should use plat_setup().
Hmm.. agreed. Thank you.
> 
> Yoichi
> 
> 
-- 
cheers, dmitry pervushin


<Prev in Thread] Current Thread [Next in Thread>