On Чтв, 2006-05-18 at 19:54 +0900, Yoichi Yuasa wrote:
> Hi,
>
> On Thu, 18 May 2006 14:00:23 +0400
> dmitry pervushin <dpervushin@ru.mvista.com> wrote:
>
> > Index: linux-malta/arch/mips/emma2rh/markeins/int-handler.S
> > ===================================================================
> > --- /dev/null
> > +++ linux-malta/arch/mips/emma2rh/markeins/int-handler.S
>
> You should rewrite the assembler interrupt handler to C code.
Why ?? Could you please comment the statement ? May be, I have
misunderstood the modern ways in linux kernel development, but I am
pretty sure that assembler interrupt handler will be faster than C
code.
>
> > Index: linux-malta/arch/mips/emma2rh/markeins/setup.c
> > ===================================================================
> > --- /dev/null
> > +++ linux-malta/arch/mips/emma2rh/markeins/setup.c
> > @@ -0,0 +1,208 @@
>
> <snip>
>
> > +}
> > +
> > +early_initcall(platform_setup);
>
> early_initcall() already haven't existed.
> You should use plat_setup().
Hmm.. agreed. Thank you.
>
> Yoichi
>
>
--
cheers, dmitry pervushin
|