linux-mips
[Top] [All Lists]

Re: [PATCH] NEC EMMA2RH support

To: dmitry pervushin <dpervushin@ru.mvista.com>
Subject: Re: [PATCH] NEC EMMA2RH support
From: Martin Michlmayr <tbm@cyrius.com>
Date: Thu, 18 May 2006 12:12:12 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <1147946423.8223.4.camel@diimka-laptop>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1147946423.8223.4.camel@diimka-laptop>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.11+cvs20060330
Some minor comments regarding the coding style:

* dmitry pervushin <dpervushin@ru.mvista.com> [2006-05-18 14:00]:
> +       Features : kernel debugging, serial terminal, NFS root fs, on-board

There shouldn't be a space before the colon.

> ===================================================================
> --- linux-malta.orig/arch/mips/Makefile
> +++ linux-malta/arch/mips/Makefile
> @@ -196,7 +196,7 @@ cflags-$(CONFIG_CPU_MIPS64R2)     += \
>  
>  cflags-$(CONFIG_CPU_R5000)   += \
>                       $(call set_gccflags,r5000,mips4,r5000,mips4,mips2) \
> -                     -Wa,--trap 
> +                     -Wa,--trap
>  
>  cflags-$(CONFIG_CPU_R5432)   += \
>                       $(call set_gccflags,r5400,mips4,r5000,mips4,mips2) \
> @@ -776,7 +776,7 @@ archclean:
>       @$(MAKE) $(clean)=arch/mips/boot
>       @$(MAKE) $(clean)=arch/mips/lasat
>  
> -# Generate <asm/offset.h 
> +# Generate <asm/offset.h

Those unrelated changes shouldn't be made.

> +// #include <linux/kdev_t.h>
> +#include <linux/types.h>
> +// #include <linux/sched.h>
> +// #include <linux/pci.h>

I think C++ style comments should't be used in the kernel.  In any
case, you could just remove them if they're not used.

-- 
Martin Michlmayr
http://www.cyrius.com/

<Prev in Thread] Current Thread [Next in Thread>