linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] Wind River 4KC PPMC Eval Board Support

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 1/2] Wind River 4KC PPMC Eval Board Support
From: "Mark.Zhan" <rongkai.zhan@windriver.com>
Date: Wed, 10 May 2006 10:41:16 +0800
Cc: linux-mips@linux-mips.org
In-reply-to: <20060509164127.GA10647@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <445C6694.6010901@windriver.com> <20060509164127.GA10647@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5 (X11/20060313)
Ralf Baechle wrote:
On Sat, May 06, 2006 at 05:04:20PM +0800, Mark.Zhan wrote:

According to your comments, I re-create the patch. Hopefully, no line-wrapped 
problems:-)
Patch 1 and 2 in the original mails are concatenated into one patch in this 
mail.

Well, this patch was still somewhat corrupt, a few spaces were missing

Huhh, I don't what's wrong with my thunderbird.

but I was somehow able to talk git into taking it.  So it's applied on
the queue branch.

  Ralf

After looking into the changeset ac58afdfac792c0583af30dbd9eae53e24c78b, I find what I want to do has been done by you:-)

For those MIPS32 boards which only use IRQ_CPU, I think, we can provide a default plat_irq_dispatch() implemention, maybe like this:

asmlinkage plat_irq_dispatch(struct pt_regs *regs)
{
        unsigned int pending = read_c0_status() & read_c0_cause();
        int irq;

        irq = ffs(pending >> 8) - 1;
        return do_IRQ(irq, regs);
}

I this it will clean up more codes......

Best Regards,
Mark.Zhan

<Prev in Thread] Current Thread [Next in Thread>