linux-mips
[Top] [All Lists]

Re: [PATCH] fix mips/Makefile to support CROSS_COMPILE from environment

To: Thiemo Seufer <ths@networkno.de>
Subject: Re: [PATCH] fix mips/Makefile to support CROSS_COMPILE from environment var
From: Tim Bird <tim.bird@am.sony.com>
Date: Mon, 08 May 2006 11:22:57 -0700
Cc: linux-mips@linux-mips.org
In-reply-to: <20060504223539.GG18218@networkno.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <445A577D.7090507@am.sony.com> <20060504205517.GF18218@networkno.de> <445A6F51.90308@am.sony.com> <20060504223539.GG18218@networkno.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5 (X11/20051201)
Thiemo Seufer wrote:
> Update to a newer version:

Of what?  I'm using a 2.6.16 kernel here.

> config CROSSCOMPILE
>       bool "Are you using a crosscompiler"
>       help
>         Say Y here if you are compiling the kernel on a different
>         architecture than the one it is intended to run on.  This is just a
>         convenience option which will select the appropriate value for
>         the CROSS_COMPILE make variable which otherwise has to be passed on
>         the command line from mips-linux-, mipsel-linux-, mips64-linux- and
>         mips64el-linux- as appropriate for a particular kernel configuration.
>         You will have to pass the value for CROSS_COMPILE manually if the
>         name prefix for your tools is different.

Hmmm.  Well, I would say that this should be pushed to mainline,
but I still think it could be improved a bit.

IMHO, the config question should be something like:
"Use cross-compiler defined by Makefile", instead of "Are you
using a crosscompiler".

My recommendation would be to apply my patch and drop the
last sentence.  Then you get the best of all worlds:
 - support for command line specification, if you use it
 - support for env. var specification, if you use it.
 - automatic prefix selection if you use this option

=============================
Tim Bird
Architecture Group Chair, CE Linux Forum
Senior Staff Engineer, Sony Electronics
=============================

<Prev in Thread] Current Thread [Next in Thread>