linux-mips
[Top] [All Lists]

Re: [PATCH] 8250_early console support for au1x00

To: Rodolfo Giometti <giometti@linux.it>
Subject: Re: [PATCH] 8250_early console support for au1x00
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Thu, 04 May 2006 19:48:47 +0400
Cc: linux-mips@linux-mips.org
In-reply-to: <20060504152048.GG19913@gundam.enneenne.com>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060504134509.GE19913@gundam.enneenne.com> <445A114B.4040404@ru.mvista.com> <20060504152048.GG19913@gundam.enneenne.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Rodolfo Giometti wrote:
On Thu, May 04, 2006 at 06:35:55PM +0400, Sergei Shtylyov wrote:

  The following 2 fragments are kind of contradictory:

I see, but I decided to keep it different since the kernel message is:

   Adding console on ttyS0 at MMIO 0x11100000 (options '115200')

and setting it as:

   Adding console on ttyS0 at AU 0x11100000 (options '115200')

sounds bad to me. :)

Yes. But the error msg emmitted by your patch would look this way, i.e. AU, not MMIO. No symmetry. :-)

And, as I said. there's not much sense in calling iomap() on Alchemy UART, UPIO_IOREMAP flag wasn't really needed...


Mmm... to be «coherent» I think it should be done...

Wouldn't hurt, just useless. So, I think no special checks are needed to avoid it. :-)

Ciao,

Rodolfo

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>