linux-mips
[Top] [All Lists]

Re: [PATCH] Physical addresses fix for au1x00 serial driver

To: Rodolfo Giometti <giometti@linux.it>
Subject: Re: [PATCH] Physical addresses fix for au1x00 serial driver
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Thu, 04 May 2006 18:27:49 +0400
Cc: linux-mips@linux-mips.org
In-reply-to: <20060504135837.GF19913@gundam.enneenne.com>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060504101112.GC19913@gundam.enneenne.com> <4459F72D.4010408@ru.mvista.com> <20060504132413.GD19913@gundam.enneenne.com> <20060504135837.GF19913@gundam.enneenne.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Rodolfo Giometti wrote:

  This is not quite correct. The UARTs take up 1 MB of memory each.

The patch:

   diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
   index 8365d5b..3473e7a 100644
   --- a/drivers/serial/8250.c
   +++ b/drivers/serial/8250.c
   @@ -1935,8 +1935,10 @@ static int serial8250_request_std_resour
        int ret = 0;
switch (up->port.iotype) {
   -    case UPIO_MEM:
        case UPIO_AU:
   +            size = 0x100000;
   +            /* fall thru */
   +    case UPIO_MEM:
                if (!up->port.mapbase)
                        break;

I'll merge this patch with my previous one ASAP...

Better just use my patch. There's no sense in calling ioremp() on UART addresses.

Ciao,

Rodolfo

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>