linux-mips
[Top] [All Lists]

Re: [PATCH] Physical addresses fix for au1x00 serial driver

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH] Physical addresses fix for au1x00 serial driver
From: Rodolfo Giometti <giometti@linux.it>
Date: Thu, 4 May 2006 15:24:13 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <4459F72D.4010408@ru.mvista.com>
Organization: GNU/Linux Device Drivers, Embedded Systems and Courses
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060504101112.GC19913@gundam.enneenne.com> <4459F72D.4010408@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.5.1+cvs20040105i
On Thu, May 04, 2006 at 04:44:29PM +0400, Sergei Shtylyov wrote:
>
>    I have already noticed and fixed this. The fix is in Andrew Morton's 
>    tree (unpublished yet). See this msg for the patch:
> 
> http://www.linux-mips.org/archives/linux-mips/2006-04/msg00029.html

I see. :)

>    This is not quite correct. The UARTs take up 1 MB of memory each.

Yes, in my patch is missing this part:

           switch (up->port.iotype) {
   +       case UPIO_AU:
   +               size = 0x100000;
   +               /* fall thru */
           case UPIO_MEM:
                   if (!up->port.mapbase)

Are you already working on 8250_early for au1x00? I'm quite ready for
the patch. :)

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@enneenne.com
Linux Device Driver                             giometti@gnudd.com
Embedded Systems                                giometti@linux.it
UNIX programming                     phone:     +39 349 2432127

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>