| To: | "Randy.Dunlap" <rdunlap@xenotime.net> |
|---|---|
| Subject: | Re: SETNAME (set nodename) in syscall.c |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Tue, 2 May 2006 17:09:58 +0100 |
| Cc: | linux-mips@linux-mips.org |
| In-reply-to: | <Pine.LNX.4.58.0604292059210.24032@shark.he.net> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <Pine.LNX.4.58.0604292059210.24032@shark.he.net> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.4.2.1i |
On Sat, Apr 29, 2006 at 09:01:59PM -0700, Randy.Dunlap wrote: > In arch/mips/syscall.c::_sys_sysmips(), case SETNAME, > isn't one of the strncpy() and strlcpy() unneeded? > > down_write(&uts_sem); > strncpy(system_utsname.nodename, nodename, len); > nodename[__NEW_UTS_LEN] = '\0'; > strlcpy(system_utsname.nodename, nodename, > sizeof(system_utsname.nodename)); > up_write(&uts_sem); Seems that came with the 2.5.70 merge and got copied and moved around a few times since. I'm pretty sure the whole sysmips(SETNAME, ...) operation is unused. Any objections again removal of sysmips(SETNAME, ...) support? Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] au1000_eth.c Power Management, driver registration and module support, Rodolfo Giometti |
|---|---|
| Next by Date: | Re: RFC: au1000_etc.c phylib rewrite, Mark Schank |
| Previous by Thread: | Re: [PATCH] au1000_eth.c Power Management, driver registration and module support, Rodolfo Giometti |
| Next by Thread: | How can I use DBAu1550 UART3 instead of UART0?, Charles C.K.Lai |
| Indexes: | [Date] [Thread] [Top] [All Lists] |