linux-mips
[Top] [All Lists]

Re: [PATCH] AU1xxxx mips_timer_interrupt() fixes

To: Herbert Valerio Riedel <hvr@hvrlab.org>
Subject: Re: [PATCH] AU1xxxx mips_timer_interrupt() fixes
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 27 Apr 2006 17:13:09 +0100
Cc: linux-mips@linux-mips.org, ppopov@embeddedalley.com
In-reply-to: <200604100901.k3A91sXm029832@phobos.hvrlab.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200604100901.k3A91sXm029832@phobos.hvrlab.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Wed, Apr 12, 2006 at 09:03:08AM +0200, Herbert Valerio Riedel wrote:

> common/au1000/irq.c was missing a mips_timer_interrupt() prototype, whereas
> in common/au1000/time.c the actual mips_timer_interrupt() implementation
> was missing an irq_exit() invocation, causing a preempt_count() leak

mips_timer_interrupt is essentially duplicated code, so this kind of
breakage is entirely avoidable but fixing and all the other time code
braindamage it will be a large project, so I applied this patch to
2.6.16-stable and master.

Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>