| To: | Win Treese <treese@acm.org> |
|---|---|
| Subject: | Re: [PATCH] fix branch emulation for floating-point exceptions |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Wed, 26 Apr 2006 22:28:57 +0100 |
| Cc: | linux-mips@linux-mips.org |
| In-reply-to: | <9B3838B8-4950-40BA-B386-0D45819C168D@acm.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <9B3838B8-4950-40BA-B386-0D45819C168D@acm.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.4.2.1i |
On Wed, Apr 26, 2006 at 03:22:22PM -0400, Win Treese wrote:
> In the branch emulation for floating-point exceptions,
> __compute_return_epc
> must determine for bc1f et al which condition code bit to test. This
> is based on bits <4:2>
> of the rt field. The switch statement to distinguish bc1f et al needs
> to use only the
> two low bits of rt, but the old code tests on the whole rt field.
> This patch masks off
> the proper bits.
One of those bugs that have managed to hide since day one ... I applied
your fix but: your mailer is converting tabs to spaces, so patch is going
to barf on the patch ...
> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
^^^^^^^^^^^^^
... and it would also break long lines ...
Ralf
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] fix branch emulation for floating-point exceptions, Win Treese |
|---|---|
| Next by Date: | Re: Crosstools for MALTA MIPS in little endian, Ralf Baechle |
| Previous by Thread: | [PATCH] fix branch emulation for floating-point exceptions, Win Treese |
| Next by Thread: | Compiling glibc for mips64, Vadivelan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |