| To: | sshtylyov@ru.mvista.com |
|---|---|
| Subject: | Re: tx49 Ether problems |
| From: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
| Date: | Mon, 17 Apr 2006 11:09:45 +0900 (JST) |
| Cc: | geoffrey.levand@am.sony.com, linux-mips@linux-mips.org |
| In-reply-to: | <444291E9.2070407@ru.mvista.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <444032A5.3030304@am.sony.com> <44415D17.1070005@ru.mvista.com> <444291E9.2070407@ru.mvista.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Sun, 16 Apr 2006 22:50:17 +0400, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote: > > This is really strange place for that #ifdef -- 'wordlength' is > > determined much earlier in this function (and stop_page is set to 0x40 > > for 8-bit case), shouldn't #ifdef be moved instead? > > What I think we actually need is more generic fix for RTL8019AS, not the > board specific hacks -- if this RX ring stop page value limitation *really* > needs to be enforced. I agree with you. Then how about something like CONFIG_NE2000_RTL8019_BYTEMODE? Also, setting 0xbad value to mem_end can skip the Product-ID checking without inflating bad_clone_list. Just a thought... --- Atsushi Nemoto |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 00/05] robust per_cpu allocation for modules, Tony Luck |
|---|---|
| Next by Date: | Re: [PATCH 00/05] robust per_cpu allocation for modules, Rusty Russell |
| Previous by Thread: | Re: tx49 Ether problems, Sergei Shtylyov |
| Next by Thread: | Re: tx49 Ether problems, Sergei Shtylyov |
| Indexes: | [Date] [Thread] [Top] [All Lists] |