linux-mips
[Top] [All Lists]

[PATCH] Au1550: make OSS drivers look pretty on loading

To: Linux-MIPS <linux-mips@linux-mips.org>
Subject: [PATCH] Au1550: make OSS drivers look pretty on loading
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Sun, 02 Apr 2006 20:25:44 +0400
Cc: Jordan Crouse <jordan.crouse@amd.com>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Calls to pr_info() without newlines caused the OSS drivers' load time messages to be printed w/o any spacing...

WBR, Sergei

PS: Forgot the signoff line again when posting the patch on Friday:

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
diff --git a/sound/oss/au1550_ac97.c b/sound/oss/au1550_ac97.c
index f38e082..0ca90a0 100644
--- a/sound/oss/au1550_ac97.c
+++ b/sound/oss/au1550_ac97.c
@@ -1950,7 +1950,7 @@ au1550_probe(void)
                goto err_dma2;
        }
 
-       pr_info("DAC: DMA%d, ADC: DMA%d", DBDMA_AC97_TX_CHAN, 
DBDMA_AC97_RX_CHAN);
+       pr_info("DAC: DMA%d, ADC: DMA%d\n", DBDMA_AC97_TX_CHAN, 
DBDMA_AC97_RX_CHAN);
 
        /* register devices */
 
@@ -2031,7 +2031,7 @@ au1550_probe(void)
 
        s->codec_base_caps = rdcodec(s->codec, AC97_RESET);
        s->codec_ext_caps = rdcodec(s->codec, AC97_EXTENDED_ID);
-       pr_info("AC'97 Base/Extended ID = %04x/%04x",
+       pr_info("AC'97 Base/Extended ID = %04x/%04x\n",
             s->codec_base_caps, s->codec_ext_caps);
 
        if (!(s->codec_ext_caps & AC97_EXTID_VRA)) {
@@ -2047,7 +2047,7 @@ au1550_probe(void)
                s->no_vra = 1;
        }
        if (s->no_vra)
-               pr_info("no VRA, interpolating and decimating");
+               pr_info("no VRA, interpolating and decimating\n");
 
        /* set mic to be the recording source */
        val = SOUND_MASK_MIC;
diff --git a/sound/oss/au1550_i2s.c b/sound/oss/au1550_i2s.c
index 529b625..9907ac0 100644
--- a/sound/oss/au1550_i2s.c
+++ b/sound/oss/au1550_i2s.c
@@ -1897,7 +1897,7 @@ au1550_probe(void)
                goto err_dma2;
        }
 
-       pr_info("DAC: DMA%d, ADC: DMA%d", DBDMA_I2S_TX_CHAN, DBDMA_I2S_RX_CHAN);
+       pr_info("DAC: DMA%d, ADC: DMA%d\n", DBDMA_I2S_TX_CHAN, 
DBDMA_I2S_RX_CHAN);
 
        /* register devices */
 
<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] Au1550: make OSS drivers look pretty on loading, Sergei Shtylyov <=