| To: | Russell King <rmk@arm.linux.org.uk> |
|---|---|
| Subject: | Re: [PATCH] serial8250: set divisor register correctly for AMD Alchemy SoC uart. Re-posted. |
| From: | Jon Anders Haugum <jonah@omegav.ntnu.no> |
| Date: | Wed, 29 Mar 2006 15:39:46 +0200 (CEST) |
| Cc: | linux-serial@vger.kernel.org, linux-mips@linux-mips.org |
| In-reply-to: | <20060327125423.GA24311@flint.arm.linux.org.uk> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20060327131437.P55909@invalid.ed.ntnu.no> <20060327125423.GA24311@flint.arm.linux.org.uk> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Mon, 27 Mar 2006, Russell King wrote: > I'm not sure whether this is a good idea - this is used to detect > an 16C850 UART, so probably should be kept as is. > > In other words, we should use serial_dl_read() / serial_dl_write() > when we're actually wanting to read or set the actual divisor, but > not for the autoconfiguration stuff. Agree. Should I send you a updated patch? -- Jon Anders Haugum |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: compilation problem with kernel 2.6.15, Krishna |
|---|---|
| Next by Date: | Using hardware watchpoint for applications debugging, colin |
| Previous by Thread: | Re: [PATCH] serial8250: set divisor register correctly for AMD Alchemy SoC uart. Re-posted., Russell King |
| Next by Thread: | [PATCH] Fix sed regexp to generate asm-offset.h, Atsushi Nemoto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |