linux-mips
[Top] [All Lists]

Re: IP22 doesn't shutdown properly

To: Martin Michlmayr <tbm@cyrius.com>
Subject: Re: IP22 doesn't shutdown properly
From: Russell King <rmk@arm.linux.org.uk>
Date: Sat, 25 Mar 2006 17:34:50 +0000
Cc: linux-mips@linux-mips.org, jblache@debian.org
In-reply-to: <20060227105236.GI12044@deprecation.cyrius.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060217225824.GE20785@deprecation.cyrius.com> <20060223221350.GA5239@deprecation.cyrius.com> <20060224190517.GA28013@lst.de> <20060227105236.GI12044@deprecation.cyrius.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Mon, Feb 27, 2006 at 10:52:36AM +0000, Martin Michlmayr wrote:
> @@ -360,10 +367,10 @@ static void ip22zilog_status_handle(stru
>                * But it does not tell us which bit has changed, we have to 
> keep
>                * track of this ourselves.
>                */
> -             if ((status & DCD) ^ up->prev_status)
> +             if ((status ^ up->prev_status) ^ DCD)

Shouldn't this be (status ^ up->prev_status) & DCD ?

>                       uart_handle_dcd_change(&up->port,
>                                              (status & DCD));
> -             if ((status & CTS) ^ up->prev_status)
> +             if ((status ^ up->prev_status) ^ CTS)

Shouldn't this be (status ^ up->prev_status) & CTS ?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

<Prev in Thread] Current Thread [Next in Thread>
  • Re: IP22 doesn't shutdown properly, Russell King <=