linux-mips
[Top] [All Lists]

Re: [PATCH] SGI VINO driver 64-bit fix / V4L ioctl compatibility la

To: "Martin Michlmayr" <tbm@cyrius.com>
Subject: Re: [PATCH] SGI VINO driver 64-bit fix / V4L ioctl compatibility layer needs fixes
From: "Mikael Nousiainen" <turja@mbnet.fi>
Date: Sat, 18 Mar 2006 10:58:12 +0200 (EET)
Cc: linux-mips@linux-mips.org
In-reply-to: <20060318015941.GY18750@deprecation.cyrius.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.GSO.4.58.0603171412170.11482@kekkonen.cs.hut.fi> <20060318015941.GY18750@deprecation.cyrius.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: SquirrelMail/1.4.3a
> * turja@mbnet.fi <turja@mbnet.fi> [2006-03-17 14:19]:
>> This patch should fix problems with VINO drivers when using a 64-bit
>> kernel.
>
> Did you test this?

To be honest, I didn't test this (as I didn't have 64-bit kernel available),
but the fix was quite trivial. Basically I only had to change one unsigned
long
back to u32 as the DMA addresses VINO uses are always 32-bit.
Nothing else should prevent the driver from working in a 64-bit environment.

>
> It looks exactly like the patch you gave me for testing a few days ago
> and that did not work...

Yup, it didn't work...

>
>> There are also other bugs which prevent V4L drivers from functioning
>> correctly when using 32-bit userland with a 64-bit kernel as the ioctl
>> compatibility layer (in drivers/media/video/compat_ioctl32.c) doesn't
>> seem
>> to handle VIDIOC_CROPCAP.
>
> ... or did I see this bug?

.... because the bug you saw was this. The compatibility layer
doesn't forward certain ioctls to the driver and only returns an error code.

Also please remember to download the newest version (0.7.1) of the
patched camsource from my web page when testing the driver.
The newest version has a couple of fixes which should allow
the application to work with the driver even if VIDIOC_CROPCAP fails.
But anyway the V4L ioctl compatibility layer needs to be fixed.

http://www.mbnet.fi/~turja/vino/


Mikael Nousiainen



<Prev in Thread] Current Thread [Next in Thread>