|To:||"'Chris Wedgwood'" <email@example.com>, "Tiwari, Rakesh" <Rakesh.Tiwari@idt.com>|
|Subject:||RE: [PATCH] IDT Interprise Processor Support for Linux 2.6.x|
|From:||"Tiwari, Rakesh" <Rakesh.Tiwari@idt.com>|
|Date:||Mon, 13 Mar 2006 13:06:52 -0800|
|Cc:||"'Ralf Baechle'" <firstname.lastname@example.org>, email@example.com|
Appreciate your feedback.
Look forward for additional comments/suggestions, if any.
* Firstly, it's really great to see this!
* A single 1.6MB patch is far from ideal, please try to break it
[rkt] Agreed, 1.6MB is a huge patch. I will try to break it down into
* You shouldn't be removing .gitignore :-)
[rkt] I think these are still there.
[rkt] The Ethernet interface/driver is integral to each processor
[rkt] Chris you hit the bulls eye. This is the only function which
[rkt] Since all the IDT's processors are primarily SoC's, the UARTS are
* There is quite a bit of extraneous white-space that could be
[rkt] Will try to clean up as much as possible...
Sorry this is a little vague and 'hand-wavy', if you post smaller logically complete patches I think you'll get better feedback where people can comment more easily. Ideally inline to the email if you can, m$ lookout/$exchange as that just makes a mess, if you have to use that then attach them as you did.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: BCM91x80A/B PCI DMA problems, Martin Michlmayr|
|Next by Date:||RE: Cross compile kernel w/ buildroot toolchain, Kurt Schwemmer|
|Previous by Thread:||RE: [PATCH] IDT Interprise Processor Support for Linux 2.6.x, Tiwari, Rakesh|
|Next by Thread:||tools to convert debian sarge to 16K page size, Fuxin Zhang|
|Indexes:||[Date] [Thread] [Top] [All Lists]|