linux-mips
[Top] [All Lists]

Re: jiffies_64 vs. jiffies

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: jiffies_64 vs. jiffies
From: Nick Piggin <nickpiggin@yahoo.com.au>
Date: Thu, 02 Mar 2006 02:00:16 +1100
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=uk+6687T9kQY+egMbUwOkw9k9w97Jg5Zop6QAOpQ5AgN3eKbh2LK9xiHi+Z7xZpxkg+wuVu+2Ojsec6a9mxtidSXX52wqJ/MdzMvtmdG2NUtcJNf2FrpkPM7CpOQT61rXFR7ZNYaCQPMt+t3CCVRGQoohTY4mTmpMuBIsYs2BLQ= ;
In-reply-to: <20060301.235750.25910018.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060301.144442.118975101.nemoto@toshiba-tops.co.jp> <20060301.210541.30439818.nemoto@toshiba-tops.co.jp> <44059915.3010800@yahoo.com.au> <20060301.235750.25910018.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1
Atsushi Nemoto wrote:
On Wed, 01 Mar 2006 23:52:37 +1100, Nick Piggin <nickpiggin@yahoo.com.au> said:


void do_timer(struct pt_regs *regs)
{
-       jiffies_64++;
-       update_times();
+       update_times(++jiffies_64);
        softlockup_tick(regs);
}


nick> jiffies_64 is not volatile so you should not have to obfuscate
nick> the code like this.

Well, do you mean it should be like this ?

        jiffies_64++;
        update_times(jiffies_64);


Yeah. It makes your patch a line smaller too!

Thanks for your comments.

Oh it was nothing really ;)

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
<Prev in Thread] Current Thread [Next in Thread>