linux-mips
[Top] [All Lists]

Re: [RFC] SMP initialization order fixes.

To: Rojhalat Ibrahim <imr@rtschenk.de>
Subject: Re: [RFC] SMP initialization order fixes.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 23 Feb 2006 11:55:27 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <43FD85C8.5040801@rtschenk.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060222190940.GA29967@linux-mips.org> <43FD85C8.5040801@rtschenk.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Thu, Feb 23, 2006 at 10:52:08AM +0100, Rojhalat Ibrahim wrote:

> Works for me with a little fix. You need to set phys_cpu_present_map
> in yosemite/smp.c. Therefore the following two lines in the patch
> are unnecessary.
> 
> > -           cpu_set(i, phys_cpu_present_map);
> > +           cpu_set(i, cpu_present_map);

In include/asm-mips/smp.h we have the define:

  #define cpu_possible_map        phys_cpu_present_map

I meant to get rid of direct references to phys_cpu_present_map so really
should have done this:

> > -           cpu_set(i, phys_cpu_present_map);
> > +           cpu_set(i, cpu_possible_map);

Anyway, I dropped this for now and will commit the patch.

Thanks for testing & fix.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>