linux-mips
[Top] [All Lists]

Re: Oops with git: do_signal32 on 64-bit

To: tbm@cyrius.com
Subject: Re: Oops with git: do_signal32 on 64-bit
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sun, 19 Feb 2006 00:06:33 +0900 (JST)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20060218145545.GX20785@deprecation.cyrius.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060217225216.GA15781@deprecation.cyrius.com> <20060218.220701.25910111.anemo@mba.ocn.ne.jp> <20060218145545.GX20785@deprecation.cyrius.com>
Sender: linux-mips-bounce@linux-mips.org
>>>>> On Sat, 18 Feb 2006 14:55:45 +0000, Martin Michlmayr <tbm@cyrius.com> 
>>>>> said:

tbm> Done now, and tested on Cobalt.

Looks good for me, except one point.
Since do_signal() return void now, do_signal32 also should return void.

Also, I think prototypes of do_signal() variant should be in
asm/signal.h or so to avoid such mistake in the future, but this might
be an another patch ...

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>