linux-mips
[Top] [All Lists]

Re: [PATCH] make I/O helpers more customizable

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] make I/O helpers more customizable
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 16 Feb 2006 23:24:46 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <20060217.013624.04769497.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060217.013624.04769497.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Fri, Feb 17, 2006 at 01:36:24AM +0900, Atsushi Nemoto wrote:

> 1. Move ioswab*() and __mem_ioswab*() to mangle-port.h.  Now io.h is
> clean from CONFIG_SGI_IP22.
> 
> 2. Pass a virtual address to *ioswab*().  Then we can provide
> mach-specific *ioswab*() and can do every evil thing based on its
> argument.  It could be useful on machines which have regions with
> different endian conversion scheme.
> 
> 3. Call __swizzle_addr*() _after_ adding mips_io_port_base.  This
> unifies the meaning of the argument of __swizzle_addr*() (always
> virtual address).  Then mach-specific __swizzle_addr*() can do every
> evil thing based on the argument.
> 
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

Looks nice.  This this is more of a cleanup so I queued it for 2.6.17.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>