linux-mips
[Top] [All Lists]

Re: Please pull drivers/scsi/dec_esp.c from Linus' git

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: Please pull drivers/scsi/dec_esp.c from Linus' git
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 16 Feb 2006 10:17:38 +0000 (GMT)
Cc: Martin Michlmayr <tbm@cyrius.com>, linux-mips@linux-mips.org
In-reply-to: <20060215150839.GA27719@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060213225331.GA5315@deprecation.cyrius.com> <20060215150839.GA27719@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 15 Feb 2006, Ralf Baechle wrote:

> > @@ -230,7 +230,7 @@
> >                     mem_start = get_tc_base_addr(slot);
> >  
> >                     /* Store base addr into esp struct */
> > -                   esp->slot = mem_start;
> > +                   esp->slot = CPHYSADDR(mem_start);
> >  
> >                     esp->dregs = 0;
> >                     esp->eregs = (void *)CKSEG1ADDR(mem_start +
> 
> I merged allmost all of the differences from mainline except this one.
> 
> Maciej, does this need the CPHYSADDR() op or not here?

 Of course not as get_tc_base_addr() returns a physical address these 
days.  Thanks for spotting this bit.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>