linux-mips
[Top] [All Lists]

Re: Fixes for uaccess.h with gcc >= 4.0.1

To: Martin Michlmayr <tbm@cyrius.com>, MIPS Linux List <linux-mips@linux-mips.org>, Stuart Anderson <anderson@netsweng.com>, David Daney <ddaney@avtrex.com>, richard@codesourcery.com
Subject: Re: Fixes for uaccess.h with gcc >= 4.0.1
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 10 Feb 2006 01:34:40 +0000
In-reply-to: <87wtg6c43s.fsf@talisman.home>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060123150507.GA18665@linux-mips.org> <87wtg6c43s.fsf@talisman.home>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Tue, Feb 07, 2006 at 08:21:11PM +0000, Richard Sandiford wrote:

> Ralf Baechle <ralf@linux-mips.org> writes:
> > I'd appreciate if somebody with gcc 4.0.1 could test this kernel patch
> > below.
> 
> Sorry in advance if this is a dup, but...

No, not a dupe.

> and this requires val (%1) to be a 64-bit value.  In the case I saw,
> gcc was using $3 for the 32-bit val, and wasn't expecting $4 to be
> clobbered.

Thanks, makes perfect sense.  I tried various other obscure things and
your patch was holding up, so I just applied it.

Thanks,

  Ralf

PS: If in the future you could include a Signed-off-by: line.

<Prev in Thread] Current Thread [Next in Thread>