linux-mips
[Top] [All Lists]

Re: [PATCH] local_r4k_flush_cache_page fix

To: linux-mips@linux-mips.org
Subject: Re: [PATCH] local_r4k_flush_cache_page fix
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Fri, 03 Feb 2006 14:14:24 +0900 (JST)
Cc: ralf@linux-mips.org
In-reply-to: <20060201.000356.25911337.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060201.000356.25911337.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
>>>>> On Wed, 01 Feb 2006 00:03:56 +0900 (JST), Atsushi Nemoto 
>>>>> <anemo@mba.ocn.ne.jp> said:
anemo> If dcache_size != icache_size or dcache_size != scache_size,
anemo> icache/scache does not flushed properly.  Use correct cache
anemo> size to calculate index value for scache/icache.

Sorry, this patch was wrong !

We should use mask value based on the waysize (not whole cache size).

And now I think it would be better to do it in __BUILD_BLAST_CACHE().

I'll post a new patch later.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>