linux-mips
[Top] [All Lists]

Re: [PATCH] Fix vgacon oops on 64-bit

To: Matt Porter <mporter@kernel.crashing.org>
Subject: Re: [PATCH] Fix vgacon oops on 64-bit
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 30 Jan 2006 18:17:54 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <20060130083321.B3098@cox.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060130083321.B3098@cox.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Mon, Jan 30, 2006 at 08:33:21AM -0700, Matt Porter wrote:

> Although I'm not running a VGA card, I noticed this building
> a working malta 32-bit defconfig (vgacon enabled) for 64-bit.
> Without it, the vgacon probe will access unmapped space when
> looking to see if a vga card is present.
> 
> Signed-off-by: Matt Porter <mporter@kernel.crashing.org>
> 
> diff --git a/include/asm-mips/vga.h b/include/asm-mips/vga.h
> index ca5cec9..1390ab6 100644
> --- a/include/asm-mips/vga.h
> +++ b/include/asm-mips/vga.h
> @@ -13,7 +13,11 @@
>   *   access the videoram directly without any black magic.
>   */
>  
> +#ifdef CONFIG_64BIT
> +#define VGA_MAP_MEM(x)       (0xffffffffb0000000UL + (unsigned long)(x))
> +#else
>  #define VGA_MAP_MEM(x)       (0xb0000000L + (unsigned long)(x))
> +#endif

Looks like driving out the devil with beelzebub.  The 0xb0000000 address
is totally platform specific and nobody ever noticed ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>