linux-mips
[Top] [All Lists]

Re: [PATCH]: Fix N32 sigsuspend syscall that causes non-fatal oopses

To: Kumba <kumba@gentoo.org>
Subject: Re: [PATCH]: Fix N32 sigsuspend syscall that causes non-fatal oopses
From: Daniel Jacobowitz <dan@debian.org>
Date: Tue, 24 Jan 2006 14:34:59 -0500
Cc: linux-mips@linux-mips.org
In-reply-to: <20060124191741.GB31197@toucan.gentoo.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060124191741.GB31197@toucan.gentoo.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.8i
On Tue, Jan 24, 2006 at 07:17:41PM +0000, Kumba wrote:
> Fix to the sigsuspend syscall so N32 userlands work without triggering
> non-fatal oopses.  Patch was originally drafted by Daniel Jacobwitz.
> 
> Problem was originally discovered via a configure test in the glib
> package.  When run, the test triggered a segmentation fault and an
> oops, as well as causing the test, and ultimately, configure, to fail.
> 
> Signed-off-by: Joshua Kinard <kumba@gentoo.org>
> ---
> 
>  linux32.c     |   19 -------------------
>  scall64-n32.S |    4 ++--
>  signal.c      |   42 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 44 insertions(+), 21 deletions(-)

If you're going to mess around with sigsuspend, there's a better option
now: take a look at the recently added TIF_RESTORE_SIGMASK (committed
last week).

Everyone really should migrate over to that approach; it fixes (among
other things) a nasty debugging corner case and some code duplication.

-- 
Daniel Jacobowitz
CodeSourcery

<Prev in Thread] Current Thread [Next in Thread>