linux-mips
[Top] [All Lists]

Re: [linux-usb-devel] [PATCH] UDC support for MIPS/AU1200 and Geode/CS55

To: Thomas Dahlmann <thomas.dahlmann@amd.com>
Subject: Re: [linux-usb-devel] [PATCH] UDC support for MIPS/AU1200 and Geode/CS5536
From: David Vrabel <dvrabel@cantab.net>
Date: Tue, 10 Jan 2006 13:16:51 +0000
Cc: Oliver Neukum <oliver@neukum.org>, linux-usb-devel@lists.sourceforge.net, Jordan Crouse <jordan.crouse@amd.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, info-linux@ldcmail.amd.com
In-reply-to: <43C39431.6020308@amd.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060109180356.GA8855@cosmic.amd.com> <200601092344.55988.oliver@neukum.org> <43C39431.6020308@amd.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Debian Thunderbird 1.0.7 (X11/20051017)
Thomas Dahlmann wrote:
> 
> The loop is for reading dwords only, so "i < bytes / UDC_DWORD_BYTES" cuts
> off remaining 1,2 or 3 bytes which are handled by the next loop.
> But you are right, incrementing by 4 may look better,  as
> 
>        for (i = 0; i < bytes - bytes % UDC_DWORD_BYTES; i+=4) {

    for (i = 0; i <= bytes - UDC_DWORD_BYTES; i += 4) {

?

David Vrabel

<Prev in Thread] Current Thread [Next in Thread>