linux-mips
[Top] [All Lists]

Re: [linux-usb-devel] [PATCH] UDC support for MIPS/AU1200 and Geode/CS55

To: linux-usb-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] [PATCH] UDC support for MIPS/AU1200 and Geode/CS5536
From: Oliver Neukum <oliver@neukum.org>
Date: Mon, 9 Jan 2006 23:44:55 +0100
Cc: "Jordan Crouse" <jordan.crouse@amd.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, info-linux@ldcmail.amd.com, thomas.dahlmann@amd.com
In-reply-to: <20060109180356.GA8855@cosmic.amd.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060109180356.GA8855@cosmic.amd.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.8
Am Montag, 9. Januar 2006 19:03 schrieb Jordan Crouse:
> >From the "two-birds-one-stone" department, I am pleased to present USB UDC
> support for both the MIPS Au1200 SoC and the Geode CS5535 south bridge.  
> Also, coming soon (in the next few days), OTG, which has been removed from
> the usb_host patch, and put into its own patch (as per David's comments).
> 
> This patch is against current linux-mips git, but it should apply for Linus's
> tree as well.
> 
> Regards,
> Jordan
> 
+        VDBG("udc_read_bytes(): %d bytes\n", bytes);
+
+        /* dwords first */
+        for (i = 0; i < bytes / UDC_DWORD_BYTES; i++) {
+               *((u32*) (buf + (i<<2))) = readl(dev->rxfifo); 
+        }

Is there any reason you don't increment by 4?

        Regards
                Oliver

<Prev in Thread] Current Thread [Next in Thread>