linux-mips
[Top] [All Lists]

Re: [PATCH] Force MMC/SD to 512 byte block sizes

To: Jordan Crouse <jordan.crouse@amd.com>
Subject: Re: [PATCH] Force MMC/SD to 512 byte block sizes
From: Russell King <rmk@arm.linux.org.uk>
Date: Fri, 6 Jan 2006 16:59:30 +0000
Cc: linux-mips@linux-mips.org, drzeus@drzeus.cx
In-reply-to: <20060106164406.GA15617@cosmic.amd.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060106164406.GA15617@cosmic.amd.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Fri, Jan 06, 2006 at 09:44:06AM -0700, Jordan Crouse wrote:
> This patch is not specific to the AU1200 SD driver, but thats what
> we used to debug and verify this, so thats why it is applied against
> the linux-mips tree.   Pierre, I'm sending this to you too, because I thought
> you may be interested.

NACK.  Please wait until the next round of patches get merged and then
revalidate this.

It's obviously wrong in the case of cards which do not support partial
block writes, and it does nothing to detect this (apart from violating
their advertised capabilities.)

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

<Prev in Thread] Current Thread [Next in Thread>