Re: [PATCH] fix local_irq_save()/local_irq_restore() when CONFIG_CPU

linux-mips

Re: [PATCH] fix local_irq_save()/local_irq_restore() when CONFIG_CPU_MIP

To:	Maxime Bizon <mbizon@freebox.fr>
Subject:	Re: [PATCH] fix local_irq_save()/local_irq_restore() when CONFIG_CPU_MIPSR2 & CONFIG_IRQ_CPU
From:	Ralf Baechle <ralf@linux-mips.org>
Date:	Thu, 22 Dec 2005 02:48:10 +0100
Cc:	linux-mips@linux-mips.org
In-reply-to:	<1135056739.9874.95.camel@sakura.staff.proxad.net>
Original-recipient:	rfc822;linux-mips@linux-mips.org
References:	<1135056739.9874.95.camel@sakura.staff.proxad.net>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Mutt/1.4.2.1i

On Tue, Dec 20, 2005 at 06:32:19AM +0100, Maxime Bizon wrote:

> 
> I was unable to get my R4KECr2 board working with CONFIG_CPU_MIPSR2 &
> CONFIG_IRQ_CPU, irq delivery is not working.
> 
> local_irq_restore() logic is to check that "flags" is non zero, and
> enable irq accordingly.
> 
> But "flags" comes directly from di, which according to mips instruction
> set, saves whole status content, not just IE bit.

There are less local_irq_save than local_irq_restore calls, so is the
preferable place for the fix.  Applied,

  Ralf

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] fix local_irq_save()/local_irq_restore() when CONFIG_CPU_MIPSR2 & CONFIG_IRQ_CPU, Maxime Bizon Re: [PATCH] fix local_irq_save()/local_irq_restore() when CONFIG_CPU_MIPSR2 & CONFIG_IRQ_CPU, Maciej W. Rozycki Re: [PATCH] fix local_irq_save()/local_irq_restore() when CONFIG_CPU_MIPSR2 & CONFIG_IRQ_CPU, Ralf Baechle <=

Previous by Date:	Re: Preempted interrupt handler, Fuxin Zhang
Next by Date:	Re: Kernel freezes in r4k_flush_icache_range() with CONFIG_CPU_MIPS32_R2, Maxime Bizon
Previous by Thread:	Re: [PATCH] fix local_irq_save()/local_irq_restore() when CONFIG_CPU_MIPSR2 & CONFIG_IRQ_CPU, Maciej W. Rozycki
Next by Thread:	[Fwd: Re: [PATCH] PNX8550 NAND flash driver], Vladimir A. Barinov
Indexes:	[Date] [Thread] [Top] [All Lists]