linux-mips
[Top] [All Lists]

Re: [PATCH] Philips PNX8550 command line patch

To: Peter Popov <ppopov@embeddedalley.com>
Subject: Re: [PATCH] Philips PNX8550 command line patch
From: "Vladimir A. Barinov" <vbarinov@ru.mvista.com>
Date: Thu, 08 Dec 2005 20:02:12 +0300
Cc: Ralf Baechle <ralf@linux-mips.org>, "'linux-mips@linux-mips.org'" <linux-mips@linux-mips.org>
In-reply-to: <20051206192105.32325.qmail@web403.biz.mail.mud.yahoo.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20051206192105.32325.qmail@web403.biz.mail.mud.yahoo.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla Thunderbird 1.0.2-6 (X11/20050513)
Hello Pete, Ralf,

Peter Popov wrote:

--- Ralf Baechle <ralf@linux-mips.org> wrote:

On Tue, Dec 06, 2005 at 09:02:14PM +0300, Vladimir
A. Barinov wrote:

This patch makes passing command line from
bootloader for Philips
PNX8550 platform.
Does it makes sense to commit this patch?
Looks ok at a quick glance.  I'll wait a bit so Pete
has a chance to comment.

Looks fine to me.
Sorry for my misunderstood but I suppose that this patch should be ignored since it used JBS board dependent code and I have STB810 that based on the code of JBS. But JBS board could have firmware that differs from that STB810 uses. So the command line could be parsed incorrectly for JBS, it's needed to check by somebody who has JBS board.

I prepared STB810 board dependent patch that include this fix for command-line parsing for STB810 board only.
So Ralf please ignore this patch though it was approved by you and Pete.

Vladimir


<Prev in Thread] Current Thread [Next in Thread>