linux-mips
[Top] [All Lists]

Re: [PATCH] Philips PNX8550 ip3106 driver deadlock fix

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Philips PNX8550 ip3106 driver deadlock fix
From: "Vladimir A. Barinov" <vbarinov@ru.mvista.com>
Date: Tue, 06 Dec 2005 21:03:00 +0300
Cc: linux-mips@linux-mips.org, ppopov@embeddedalley.com
In-reply-to: <20051206180035.GG2698@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4395D05C.9060408@ru.mvista.com> <20051206180035.GG2698@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla Thunderbird 1.0.2-6 (X11/20050513)
Ralf Baechle wrote:

On Tue, Dec 06, 2005 at 08:54:36PM +0300, Vladimir A. Barinov wrote:

This is a patch that fixes spin_lock deadlock in serial ip3106 driver.
The spin_lock_irq(&port->lock,flags) is already called in generic driver serial_core.c before
port->ops->start_tx().
So the second call of spin_lock_irq(&port->lock, flags) leads to deadlock. This could be verified in PREEMPT_DESCTOP case when
these options are enabled:
CONFIG_DEBUG_PREEMPT=y
CONFIG_DEBUG_SPINLOCK=y

Serial drivers are maintained by rmk+serial@arm.linux.org.uk, please send
to him.
Ok, thank you.

 Ralf




<Prev in Thread] Current Thread [Next in Thread>