linux-mips
[Top] [All Lists]

Re: [PATCH] Philips PNX8550 ip3106 driver deadlock fix

To: "Vladimir A. Barinov" <vbarinov@ru.mvista.com>
Subject: Re: [PATCH] Philips PNX8550 ip3106 driver deadlock fix
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 6 Dec 2005 18:00:35 +0000
Cc: linux-mips@linux-mips.org, ppopov@embeddedalley.com
In-reply-to: <4395D05C.9060408@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4395D05C.9060408@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Tue, Dec 06, 2005 at 08:54:36PM +0300, Vladimir A. Barinov wrote:

> This is a patch that fixes spin_lock deadlock in serial ip3106 driver.
> The spin_lock_irq(&port->lock,flags) is already called in generic driver 
> serial_core.c before
> port->ops->start_tx().
> So the second call of spin_lock_irq(&port->lock, flags) leads to 
> deadlock. This could be verified in PREEMPT_DESCTOP case when
> these options are enabled:
> CONFIG_DEBUG_PREEMPT=y
> CONFIG_DEBUG_SPINLOCK=y

Serial drivers are maintained by rmk+serial@arm.linux.org.uk, please send
to him.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>