linux-mips
[Top] [All Lists]

Re: [PATCH] Fix board type in db1x00

To: Dan Malek <dan@embeddedalley.com>
Subject: Re: [PATCH] Fix board type in db1x00
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 29 Nov 2005 16:51:48 +0000
Cc: Jordan Crouse <jordan.crouse@amd.com>, linux-mips@linux-mips.org
In-reply-to: <6dabaec28e238ccc915f20f51ee28327@embeddedalley.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20051122221526.GZ18119@cosmic.amd.com> <6dabaec28e238ccc915f20f51ee28327@embeddedalley.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Tue, Nov 22, 2005 at 05:31:20PM -0500, Dan Malek wrote:

> On Nov 22, 2005, at 5:15 PM, Jordan Crouse wrote:
> 
> >+    /* Set the platform # */
> >+#if defined (CONFIG_MIPS_DB1550)
> >+    mips_machtype = MACH_DB1550;
> >+#elif       defined (CONFIG_MIPS_DB1500)
> >+    mips_machtype = MACH_DB1500;
> >+#elif       defined (CONFIG_MIPS_DB1100)
> >+    mips_machtype = MACH_DB1100;
> >+#else
> >+    mips_machtype = MACH_DB1000;
> >+#endif
> 
> Can't we just do something like
>       #define MACH_ALCHEMY_TYPE  xxxxx
> 
> in the include files and not have this mess in the
> actual code?  Then, all we have to do here is:
> 
>       mips_machtype = MACH_ALCHEMY_TYPE;

But we don't have a nice space for this in header files either right now.
So I'll apply this one but if you come up with something better I'll
certainly appreciate it.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>