Re: [PATCH] Fix board type in db1x00

[Ralf Baechle <ralf@linux-mips.org>]

On Tue, Nov 22, 2005 at 05:31:20PM -0500, Dan Malek wrote:

> On Nov 22, 2005, at 5:15 PM, Jordan Crouse wrote:
> 
> >+    /* Set the platform # */
> >+#if defined (CONFIG_MIPS_DB1550)
> >+    mips_machtype = MACH_DB1550;
> >+#elif       defined (CONFIG_MIPS_DB1500)
> >+    mips_machtype = MACH_DB1500;
> >+#elif       defined (CONFIG_MIPS_DB1100)
> >+    mips_machtype = MACH_DB1100;
> >+#else
> >+    mips_machtype = MACH_DB1000;
> >+#endif
> 
> Can't we just do something like
>       #define MACH_ALCHEMY_TYPE  xxxxx
> 
> in the include files and not have this mess in the
> actual code?  Then, all we have to do here is:
> 
>       mips_machtype = MACH_ALCHEMY_TYPE;

But we don't have a nice space for this in header files either right now.
So I'll apply this one but if you come up with something better I'll
certainly appreciate it.

  Ralf