| To: | Dan Malek <dan@embeddedalley.com> |
|---|---|
| Subject: | Re: [PATCH] Fix board type in db1x00 |
| From: | Matej Kupljen <matej.kupljen@ultra.si> |
| Date: | Wed, 23 Nov 2005 07:31:37 +0100 |
| Cc: | Jordan Crouse <jordan.crouse@amd.com>, linux-mips@linux-mips.org, ralf@linux-mips.org |
| In-reply-to: | <6dabaec28e238ccc915f20f51ee28327@embeddedalley.com> |
| Organization: | Ultra d.o.o. |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20051122221526.GZ18119@cosmic.amd.com> <6dabaec28e238ccc915f20f51ee28327@embeddedalley.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
Hi > > + /* Set the platform # */ > > +#if defined (CONFIG_MIPS_DB1550) > > + mips_machtype = MACH_DB1550; > > +#elif defined (CONFIG_MIPS_DB1500) > > + mips_machtype = MACH_DB1500; > > +#elif defined (CONFIG_MIPS_DB1100) > > + mips_machtype = MACH_DB1100; > > +#else > > + mips_machtype = MACH_DB1000; > > +#endif > > Can't we just do something like > #define MACH_ALCHEMY_TYPE xxxxx > > in the include files and not have this mess in the > actual code? Then, all we have to do here is: > > mips_machtype = MACH_ALCHEMY_TYPE; I prefer Dan's suggestion, if it counts. And please, don't forget about DB1200 board also. I already sent some minor patches, but they didn't get in :( BR, Matej |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Timer interrupt handler problem, Co Ngai Fung |
|---|---|
| Next by Date: | Re: Saving arguments on the stack, Ralf Baechle |
| Previous by Thread: | Re: Fix board type in db1x00, Jordan Crouse |
| Next by Thread: | Re: [PATCH] Fix board type in db1x00, Dan Malek |
| Indexes: | [Date] [Thread] [Top] [All Lists] |