linux-mips
[Top] [All Lists]

Re: Fix board type in db1x00

To: "Dan Malek" <dan@embeddedalley.com>
Subject: Re: Fix board type in db1x00
From: "Jordan Crouse" <jordan.crouse@amd.com>
Date: Tue, 22 Nov 2005 18:18:45 -0700
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <968d9f47767cad14f9924abc1d07972b@embeddedalley.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20051122221526.GZ18119@cosmic.amd.com> <6dabaec28e238ccc915f20f51ee28327@embeddedalley.com> <20051123001534.GA18119@cosmic.amd.com> <968d9f47767cad14f9924abc1d07972b@embeddedalley.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.11
On 22/11/05 19:24 -0500, Dan Malek wrote:
> 
> On Nov 22, 2005, at 7:15 PM, Jordan Crouse wrote:
> 
> >....  That means either the mess goes in here or it goes
> >in asm-mips/mach-db1x00/db1x00.h,
> 
> You are already doing this for other things, like the BCSR
> differences with the db1550.  Why not put it all on one place?
> You could even generate out of the Kconfig process and
> not need it in any file. :-)  The problem is if you propagate
> stuff like this "...  because there isn't an include file ..." others
> will also take that attitude.  Someone has to start the
> process.  For something as generic as these boards, the
> next one should simply be an include file update, not the
> need to edit various source files as is necessary today.

I'll buy into the general idea, but I'll defer to Ralf to see if
he wants us to start inflicting this on the tree, or if he would
just prefer to let sleeping dogs lay.  One one hand, its nice to 
clean things up, but on the other hand, we're not making any more
DB boards :( so its doubtful the ugliness will grow much further then
this.

Thanks for your comments,
Jordan

-- 
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>


<Prev in Thread] Current Thread [Next in Thread>