linux-mips
[Top] [All Lists]

Re: [PATCH] Fix board type in db1x00

To: "Jordan Crouse" <jordan.crouse@amd.com>
Subject: Re: [PATCH] Fix board type in db1x00
From: Dan Malek <dan@embeddedalley.com>
Date: Tue, 22 Nov 2005 17:31:20 -0500
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20051122221526.GZ18119@cosmic.amd.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20051122221526.GZ18119@cosmic.amd.com>
Sender: linux-mips-bounce@linux-mips.org

On Nov 22, 2005, at 5:15 PM, Jordan Crouse wrote:

+       /* Set the platform # */
+#if    defined (CONFIG_MIPS_DB1550)
+       mips_machtype = MACH_DB1550;
+#elif  defined (CONFIG_MIPS_DB1500)
+       mips_machtype = MACH_DB1500;
+#elif  defined (CONFIG_MIPS_DB1100)
+       mips_machtype = MACH_DB1100;
+#else
+       mips_machtype = MACH_DB1000;
+#endif

Can't we just do something like
        #define MACH_ALCHEMY_TYPE  xxxxx

in the include files and not have this mess in the
actual code?  Then, all we have to do here is:

        mips_machtype = MACH_ALCHEMY_TYPE;


Thanks.

        -- Dan


<Prev in Thread] Current Thread [Next in Thread>