| To: | linux-mips@linux-mips.org |
|---|---|
| Subject: | [PATCH] define MAX_UDELAY_MS |
| From: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
| Date: | Sat, 05 Nov 2005 02:02:54 +0900 (JST) |
| Cc: | ralf@linux-mips.org |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| Sender: | linux-mips-bounce@linux-mips.org |
If HZ was 1000, mdelay(2) cause overflow on multiplication in __udelay. We should define MAX_UDELAY_MS properly to prevent this. Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> diff --git a/include/asm-mips/delay.h b/include/asm-mips/delay.h --- a/include/asm-mips/delay.h +++ b/include/asm-mips/delay.h @@ -84,4 +84,13 @@ static inline void __udelay(unsigned lon #define udelay(usecs) __udelay((usecs),__udelay_val) +/* make sure "usecs *= ..." in udelay do not overflow. */ +#if HZ >= 1000 +#define MAX_UDELAY_MS 1 +#elif HZ <= 200 +#define MAX_UDELAY_MS 5 +#else +#define MAX_UDELAY_MS (1000 / HZ) +#endif + #endif /* _ASM_DELAY_H */ |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.6.14 on Au1550 panics in free_hot_cold_page from init, Peter Popov |
|---|---|
| Next by Date: | Re: [PATCH] define MAX_UDELAY_MS, Ralf Baechle |
| Previous by Thread: | 2.6.14 on Au1550 panics in free_hot_cold_page from init, Clem Taylor |
| Next by Thread: | Re: [PATCH] define MAX_UDELAY_MS, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |