linux-mips
[Top] [All Lists]

Re: Fix zero length sys_cacheflush

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: Fix zero length sys_cacheflush
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 19 Oct 2005 16:57:59 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20051019.232222.59465169.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20051019.195714.89066462.nemoto@toshiba-tops.co.jp> <20051019132902.GE2616@linux-mips.org> <20051019.232222.59465169.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Wed, Oct 19, 2005 at 11:22:22PM +0900, Atsushi Nemoto wrote:

> BTW, sparse complains for this "unsigned long __user addr".
> 
> asmlinkage int sys_cacheflush(unsigned long __user addr,
>       unsigned long bytes, unsigned int cache)
> 
> /work/git/linux-mips/arch/mips/mm/cache.c:59:7: warning: dereference of 
> noderef expression
> 
> I suppose the "unsigned long __user addr" means that the "addr"
> variable itself is an userspace object.  So its usage is wrong, isn't
> it?

It didn't complain about this use in the past.  Anyway, time to do another
pass with sparse over the code; sparse developers have invented alot of new
creative warnings ;-)

  Ralf

<Prev in Thread] Current Thread [Next in Thread>